Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test client unsubscribing #18

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix test client unsubscribing #18

merged 1 commit into from
Sep 12, 2023

Conversation

Dragemil
Copy link
Collaborator

Yeaaah, so the unsubscribing wasn't working and I somehow didn't test it on the side. It seems now it's fine.

jakubfijalkowski
jakubfijalkowski approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jakubfijalkowski jakubfijalkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the test client tests inside this solution, somehow?

@Dragemil
Copy link
Collaborator Author

One thing I can think of for testing here is basically having an integration test with some project in minimal API style. It would use both the main publisher lib as well as the client. What do you think about that?

@jakubfijalkowski
Copy link
Member

I'm more than OK with that! :)

@Dragemil Dragemil merged commit 8813c08 into main Sep 12, 2023
3 checks passed
@Dragemil Dragemil deleted the publisher/fix-test-client-unsubscribing branch September 12, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubfijalkowski jakubfijalkowski jakubfijalkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dragemil @jakubfijalkowski